Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct some accessibility issues #213

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

drmenzelit
Copy link
Contributor

PR for issue #212

  • Added an empty alternative text to the language flags and some other decorative images
  • Added alternative text to DigitalOcean logo/link
  • Added alternative text to FreeCAD logo/h1
  • Changed <div id="main"... to <main>

There are other things that need to be changed, but probably you need to discuss how first in your team:

  • Add a h1 to each page (and maintain the correct heading hierarchie h1->h2->h3...)
  • Check the color contrast for text and links
  • Mark the current language as selected (you see the flag of the current selected language, but there is no information for screenreader users)

Copy link
Member

@chennes chennes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, all these changes look good to me.

@Reqrefusion
Copy link
Member

There are other things that need to be changed, but probably you need to discuss how first in your team:

* Add a h1 to each page (and maintain the correct heading hierarchie h1->h2->h3...)

* Check the color contrast for text and links

* Mark the current language as selected (you see the flag of the current selected language, but there is no information for screenreader users)

I don't see why these things need to be discussed. You can do these as you wish. These are not things that change the appearance beyond recognition. They basically just increase accessibility. However, if you think there is a big change, you can show it in another PR with before and after pictures.

Copy link
Member

@yorikvanhavre yorikvanhavre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good and are more than welcome! Thanks for taking on that!

Just a question, is adding alt="" doing better than nothing? Couldn't find that info...

About your proposed further changes, of course, please do!! We should definitely aim for state-of-the-art accessibility

@drmenzelit
Copy link
Contributor Author

@yorikvanhavre
Copy link
Member

@yorikvanhavre yorikvanhavre merged commit 2192c7b into FreeCAD:main Nov 21, 2024
1 check passed
@yorikvanhavre
Copy link
Member

And thanks for the contribution! If you have more of those in the future, they will be more than welcome 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants