Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected]: fix build error use tcl-tk v8 #648

Closed
wants to merge 1 commit into from

Conversation

ipatch
Copy link
Collaborator

@ipatch ipatch commented Dec 2, 2024

brew style freecad/freecad/[NAME_OF_FORMULA_FILE] 

output from running above command should output something similiar to the below

1 file inspected, no offenses detected
  • Have you ensured your commit passed audit checks, ie.
brew audit freecad/freecad/[NAME_OF_FORMULA_FILE] --online --new-formula

Not all PRs require passing these checks ie. adding [no ci] in the commit message will prevent the CI from running but PRs that change formula files generally should run through the CI checks that way new bottles are built and uploaded to the repository thus not having to build all formula from source but rather installing from a bottle (significantly faster 🐰 ... 🐢)

For more information about this template file learn more

@ipatch ipatch changed the title [email protected]: fix build error with tcl-tk v9 [email protected]: fix build error use tcl-tk v8 Dec 2, 2024
@ipatch
Copy link
Collaborator Author

ipatch commented Dec 2, 2024

this PR should fix the below configure, build, and install errors,

-- Info: TKIVtk and TKIVtkDraw toolkits excluded due to VTK usage is disabled
-- Info: The directories of 3rdparty headers:
        /home/linuxbrew/.linuxbrew/opt/tcl-tk/include/tcl-tk
        /home/linuxbrew/.linuxbrew/opt/freetype/include/freetype2
        /home/linuxbrew/.linuxbrew/opt/freeimage/include
        /home/linuxbrew/.linuxbrew/opt/tbb/include
        /home/linuxbrew/.linuxbrew/opt/rapidjson/include
CMake Error at CMakeLists.txt:869 (message):
  Could not find libraries of used third-party products:
  3RDPARTY_TK_LIBRARY_DIR


-- Info: The directories of 3rdparty libraries:
        /home/linuxbrew/.linuxbrew/opt/tcl-tk/lib
        /home/linuxbrew/.linuxbrew/opt/freetype/lib
        /home/linuxbrew/.linuxbrew/opt/freeimage/lib
        /home/linuxbrew/.linuxbrew/opt/tbb/lib
--
Info: (15:36:51) Start collecting all OCCT header files into /home/brewer/tmp/homebrew/opencascadeA7.7.2-20241202-132313-zfw7s1/occt-V7_7_2/build/inc ...
-- Info: (15:36:51) Compare FILES with files in package directories...
-- Info: (15:36:51) Create header-links in inc folder...
-- Info: (15:36:51) Checking headers in inc folder...
-- Info: (15:36:51) End the collecting
-- Info: (15:36:51) OCCT toolkits processed
-- Info: (15:36:51) OCCT configuration files prepared
-- Configuring incomplete, errors occurred!
[ 41%] Building CXX object src/TKDraw/CMakeFiles/TKDraw.dir/__/DrawTrSurf/DrawTrSurf_BSplineCurve.cxx.o
cd /home/brewer/tmp/homebrew/opencascadeA7.7.2-20241202-134232-204w28/occt-V7_7_2/build/src/TKDraw && /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/linux/super/g++-11 -DHAVE_FREEIMAGE -DHAVE_FREETYPE -DHAVE_OPENGL_EXT -DHAVE_RAPIDJSON -DHAVE_TBB -DHAVE_TK -DHAVE_XLIB -DOCC_CONVERT_SIGNALS -DTKDraw_EXPORTS -I/home/linuxbrew/.linuxbrew/opt/tcl-tk@8/include/tcl-tk -I/home/linuxbrew/.linuxbrew/opt/freetype/include/freetype2 -I/home/linuxbrew/.linuxbrew/opt/freeimage/include -I/home/linuxbrew/.linuxbrew/opt/tbb/include -I/home/linuxbrew/.linuxbrew/opt/rapidjson/include -I/home/brewer/tmp/homebrew/opencascadeA7.7.2-20241202-134232-204w28/occt-V7_7_2/build/include/opencascade -fexceptions -fPIC -Wall -Wextra -O3 -DNDEBUG -s -std=gnu++11 -fPIC -MD -MT src/TKDraw/CMakeFiles/TKDraw.dir/__/DrawTrSurf/DrawTrSurf_BSplineCurve.cxx.o -MF CMakeFiles/TKDraw.dir/__/DrawTrSurf/DrawTrSurf_BSplineCurve.cxx.o.d -o CMakeFiles/TKDraw.dir/__/DrawTrSurf/DrawTrSurf_BSplineCurve.cxx.o -c /home/brewer/tmp/homebrew/opencascadeA7.7.2-20241202-134232-204w28/occt-V7_7_2/src/DrawTrSurf/DrawTrSurf_BSplineCurve.cxx
/home/brewer/tmp/homebrew/opencascadeA7.7.2-20241202-134232-204w28/occt-V7_7_2/src/StdPrs/StdPrs_BRepFont.cxx: In member function ‘Standard_Boolean StdPrs_BRepFont::renderGlyph(Standard_Utf32Char, TopoDS_Shape&)’:
/home/brewer/tmp/homebrew/opencascadeA7.7.2-20241202-134232-204w28/occt-V7_7_2/src/StdPrs/StdPrs_BRepFont.cxx:460:30: error: invalid conversion from ‘unsigned char*’ to ‘const char*’ [-fpermissive]
  460 |     const char* aTags      = &anOutline->tags[aStartIndex];
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                              |
      |                              unsigned char*
make[2]: *** [src/TKV3d/CMakeFiles/TKV3d.dir/build.make:796: src/TKV3d/CMakeFiles/TKV3d.dir/__/StdPrs/StdPrs_BRepFont.cxx.o] Error 1
make[2]: Leaving directory '/home/brewer/tmp/homebrew/opencascadeA7.7.2-20241202-134232-204w28/occt-V7_7_2/build'
make[1]: *** [CMakeFiles/Makefile2:2271: src/TKV3d/CMakeFiles/TKV3d.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 41%] Building CXX object src/TKDraw/CMakeFiles/TKDraw.dir/__/DrawTrSurf/
to "$ORIGIN/../lib"
Error: An exception occurred within a child process:
  MethodDeprecatedError: Calling gsub!(before, after, false) is deprecated! Use gsub!(before, after, audit_result: false) instead.
Please report this issue to the freecad/homebrew-freecad tap (not Homebrew/brew or Homebrew/homebrew-core), or even better, submit a PR to fix it:
  /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/freecad/homebrew-freecad/Formula/[email protected]:107

@ipatch ipatch self-assigned this Dec 2, 2024
@ipatch ipatch added the pr-pull label Dec 2, 2024
github-actions bot pushed a commit that referenced this pull request Dec 2, 2024
@ipatch
Copy link
Collaborator Author

ipatch commented Dec 2, 2024

resolved with commit #808 daa0424

@ipatch ipatch closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant