Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devcontainer #457

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Devcontainer #457

wants to merge 8 commits into from

Conversation

blieusong
Copy link
Contributor

@blieusong blieusong commented Feb 20, 2022

Hi, I would like to resume my work on PR #399 so I have added devcontainer configuration files to the project.

It should be harmless, and would allow anyone to spin off a FreeTDS dev environnement very quickly, at home, on Github Codespaces, or on Gitpod.

That includes running instances of MSSQL Server and Sybase ASE 16

Also made a tiny fix to a .gitignore file.

@fziglio
Copy link

fziglio commented Mar 5, 2022

The series looks still work in progress. The commit c86cd08 looks good beside the message, at least something like Ignore autogenerated sysdep_types.h.

The devcontainer setup looks a bit personal. For instance most of containers are on your account.

@blieusong
Copy link
Contributor Author

Hi, It's quite functional. I'm using it without hiccups so far.

I use my Docker account because I don't have alternatives. If it's fine with you it's possible to create a freetds account. Then the docker images would be built with the latest freetds releases?

I'm also not aware of official Sybase ASE images. Hence why I'm using one I made. It's functional as well, but you can review it if you are curious about how it's made. https://github.com/blieusong/sybase-ase-docker. This could also be moved under a more official umbrella if you think it works well enough.

In short, this is very convenient for testing and debugging purposes (I'm finding many issues with n(var)char and unichar datatypes).

@fziglio
Copy link

fziglio commented Mar 10, 2022

Not saying it's not functional. However is not bound to project, nor with account not with support. What about a README file in the directory (maybe in markdown notation) stating that this is not official? I know docker containers are useful (I'm currently working on the "cloud") but I found security is a bit poor. Not saying that you could inject malicious code in the containers but some people could do if they hack your account, or if they hack docker hub account (I think report about hacking accounts are reported monthly these days).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants