fix: phpstan errors

composer.json

@@ -70,6 +70,7 @@
         "analyse:phpstan": "Run static analysis"
     },
     "require-dev": {
-        "flarum/phpstan": "*"
+        "flarum/phpstan": "*",
+        "flarum/pusher": "*"
     }
 }

extend.php

@@ -13,6 +13,7 @@
 
 use Flarum\Api\Controller;
 use Flarum\Api\Serializer;
+use Flarum\Discussion\Discussion;
 use Flarum\Discussion\Event\Started;
 use Flarum\Discussion\Filter\DiscussionFilterer;
 use Flarum\Discussion\Search\DiscussionSearcher;
@@ -41,6 +42,9 @@
     new Extend\Locales(__DIR__.'/resources/locale'),
 
     (new Extend\Model(User::class))
+        ->cast('votes', 'int')
+        ->cast('rank', 'string')
+        ->cast('last_vote_time', 'datetime')
         ->belongsToMany('ranks', Rank::class, 'rank_users'),
 
     (new Extend\Model(Post::class))
@@ -55,6 +59,10 @@
             return $post->hasMany(Vote::class, 'post_id');
         }),
 
+    (new Extend\Model(Discussion::class))
+        ->cast('votes', 'int')
+        ->cast('hotness', 'float'),
+
     (new ExtensionSettings())
         ->setPrefix('fof-gamification.')
         ->addKeys([

src/AddDiscussionData.php

@@ -22,6 +22,7 @@ public function __invoke(BasicDiscussionSerializer $serializer, Discussion $disc
         $actor = $serializer->getActor();
 
         if (!$actor->isGuest() && $actor->exists && $post) {
+            /** @phpstan-ignore-next-line */
             $vote = $post->actualvotes->first();
 
             $attributes['hasUpvoted'] = $vote && $vote->isUpvote();

src/AddPostData.php

@@ -35,6 +35,7 @@ public function __invoke(PostSerializer $serializer, Post $post, array $attribut
 
         if ($canSeeVotes) {
             if ($actor->exists) {
+                /** @phpstan-ignore-next-line */
                 $vote = $post->actualvotes->first();
 
                 $attributes['hasUpvoted'] = $vote && $vote->isUpvote();
@@ -44,6 +45,7 @@ public function __invoke(PostSerializer $serializer, Post $post, array $attribut
                 $attributes['hasDownvoted'] = null;
             }
             $attributes['canSeeVotes'] = $canSeeVotes;
+            /** @phpstan-ignore-next-line */
             $attributes['votes'] = $post->actualvotes_sum_value;
         } else {
             $attributes['votes'] = null;

src/Api/Controllers/ConvertLikesController.php

@@ -32,21 +32,12 @@ class ConvertLikesController implements RequestHandlerInterface
      */
     protected $gamification;
 
-    /**
-     * @param SettingsRepositoryInterface $settings
-     * @param Gamification                $gamification
-     */
     public function __construct(SettingsRepositoryInterface $settings, Gamification $gamification)
     {
         $this->settings = $settings;
         $this->gamification = $gamification;
     }
 
-    /**
-     * @param ServerRequestInterface $request
-     *
-     * @return int
-     */
     public function handle(ServerRequestInterface $request): ResponseInterface
     {
         RequestUtil::getActor($request)->assertAdmin();

src/Api/Controllers/CreateRankController.php

@@ -29,20 +29,11 @@ class CreateRankController extends AbstractCreateController
      */
     protected $bus;
 
-    /**
-     * @param Dispatcher $bus
-     */
     public function __construct(Dispatcher $bus)
     {
         $this->bus = $bus;
     }
 
-    /**
-     * @param ServerRequestInterface $request
-     * @param Document               $document
-     *
-     * @return mixed
-     */
     protected function data(ServerRequestInterface $request, Document $document)
     {
         return $this->bus->dispatch(

src/Api/Controllers/DeleteRankController.php

@@ -25,17 +25,11 @@ class DeleteRankController extends AbstractDeleteController
      */
     protected $bus;
 
-    /**
-     * @param Dispatcher $bus
-     */
     public function __construct(Dispatcher $bus)
     {
         $this->bus = $bus;
     }
 
-    /**
-     * @param ServerRequestInterface $request
-     */
     protected function delete(ServerRequestInterface $request)
     {
         $this->bus->dispatch(

src/Api/Controllers/DeleteTopImageController.php

@@ -33,18 +33,12 @@ class DeleteTopImageController extends AbstractDeleteController
      */
     protected $paths;
 
-    /**
-     * @param SettingsRepositoryInterface $settings
-     */
     public function __construct(SettingsRepositoryInterface $settings, Paths $paths)
     {
         $this->settings = $settings;
         $this->paths = $paths;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     protected function delete(ServerRequestInterface $request)
     {
         $id = Arr::get($request->getQueryParams(), 'id');

src/Api/Controllers/ListRanksController.php

@@ -19,17 +19,8 @@
 
 class ListRanksController extends AbstractListController
 {
-    /**
-     * @var RankSerializer
-     */
     public $serializer = RankSerializer::class;
 
-    /**
-     * @param ServerRequestInterface $request
-     * @param Document               $document
-     *
-     * @return mixed
-     */
     protected function data(ServerRequestInterface $request, Document $document)
     {
         return Rank::all();

src/Api/Controllers/OrderByPointsController.php

@@ -23,29 +23,18 @@ class OrderByPointsController extends AbstractListController
 {
     public $serializer = UserSerializer::class;
 
-    /**
-     * @var array
-     */
     public $include = ['ranks'];
 
     /**
      * @var Gamification
      */
     protected $gamification;
 
-    /**
-     * @param Gamification $gamification
-     */
     public function __construct(Gamification $gamification)
     {
         $this->gamification = $gamification;
     }
 
-    /**
-     * @param ServerRequestInterface $request
-     *
-     * @return mixed
-     */
     protected function data(ServerRequestInterface $request, Document $document)
     {
         if (RequestUtil::getActor($request)->cannot('fof.gamification.viewRankingPage')) {

src/Api/Controllers/UpdateRankController.php

@@ -29,20 +29,11 @@ class UpdateRankController extends AbstractShowController
      */
     protected $bus;
 
-    /**
-     * @param Dispatcher $bus
-     */
     public function __construct(Dispatcher $bus)
     {
         $this->bus = $bus;
     }
 
-    /**
-     * @param ServerRequestInterface $request
-     * @param Document               $document
-     *
-     * @return mixed
-     */
     protected function data(ServerRequestInterface $request, Document $document)
     {
         return $this->bus->dispatch(

src/Api/Controllers/UploadTopImageController.php

@@ -41,9 +41,6 @@ class UploadTopImageController extends ShowForumController
      */
     protected $imageManager;
 
-    /**
-     * @param SettingsRepositoryInterface $settings
-     */
     public function __construct(SettingsRepositoryInterface $settings, Paths $paths, ImageManager $imageManager)
     {
         $this->settings = $settings;

src/Gamification.php

@@ -66,7 +66,7 @@ public function calculateHotness($discussion)
     /**
      * @return mixed
      */
-    public function orderByPoints($limit, $offset)
+    public function orderByPoints(int $limit, int $offset)
     {
         $blockedUsers = explode(', ', $this->settings->get('fof-gamification.blockedUsers'));
 

src/Listeners/AddVoteHandler.php

@@ -55,9 +55,9 @@ public function handle(Posted $event)
             $vote->value = 1;
             $vote->save();
 
-            $ranks = Rank::where('points', '<=', $actor->votes)->get();
+            $ranks = Rank::query()->where('points', '<=', $actor->votes)->get();
 
-            if ($ranks) {
+            if (count($ranks) > 0) {
                 $actor->ranks()->detach();
                 $actor->ranks()->attach($ranks);
             }

src/Listeners/SaveVotesToDatabase.php

@@ -105,7 +105,7 @@ public function vote(Post $post, bool $isDownvoted, bool $isUpvoted, User $actor
         } else {
             if ($isUpvoted) {
                 $vote->value = 1;
-            } elseif ($isDownvoted) {
+            } else {
                 $vote->value = -1;
             }
         }

src/LoadActorVoteRelationship.php

@@ -46,6 +46,7 @@ public static function sumRelation($controller, $data): void
         }
 
         if ($loadable) {
+            /** @phpstan-ignore-next-line */
             $loadable->loadSum('actualvotes', 'value');
         }
     }

src/Notification/VoteBlueprint.php

@@ -77,7 +77,7 @@ public static function getSubjectModel()
     /**
      * Get the name of the view to construct a notification email with.
      *
-     * @return string
+     * @return array<string, string>
      */
     public function getEmailView()
     {

src/Rank.php

@@ -14,6 +14,12 @@
 use Flarum\Database\AbstractModel;
 use Flarum\User\User;
 
+/**
+ * @property int    $id
+ * @property string $name
+ * @property string $color
+ * @property int    $points
+ */
 class Rank extends AbstractModel
 {
     /**

src/Vote.php

@@ -17,20 +17,20 @@
 use Flarum\User\User;
 
 /**
- * @property int id
- * @property int user_id
- * @property int post_id
- * @property int value
+ * @property int $id
+ * @property int $user_id
+ * @property int $post_id
+ * @property int $value
  * @property Post $post
  * @property User $user
  */
 class Vote extends AbstractModel
 {
     protected $table = 'post_votes';
 
-    protected $dates = [
-        'created_at',
-        'updated_at',
+    protected $casts = [
+        'created_at' => 'datetime',
+        'updated_at' => 'datetime',
     ];
 
     protected $fillable = [