-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installation with Symfony 7 #549
Conversation
Not sure about the tests as they even fail on Symfony 6. @dbu do you have any idea they seems also failed last time on target branch: https://github.com/FriendsOfSymfony/FOSHttpCache/actions/runs/6640786360/job/18041892112 |
i am fixing the regression with the tests in #550 unfortunately i noticed that the RequestMatcher disappeared from symfony/http-foundation. we need to find a solution for that, did not yet investigate. |
Looks like we need a bridge there between the 2 classes based on the Symfony Upgrade:
but not sure how much compatible they are. |
i think supporting both should be less difficult than i feared: #551 |
fixed it in the 2.x branch, can you please rebase? |
a2cdf15
to
fce04a4
Compare
the return type declarations would be a BC break if somebody overwrote the store method our trait defines. the safe thing is to do a new major version of foshttpcache to add return types. |
continuing in #552 |
Requires another update: