Update Client Manager

FriendsOfSymfony · Sep 14, 2018 · 24c2595 · 24c2595
1 parent b1271e1
commit 24c2595
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 45 deletions.
diff --git a/Entity/ClientManager.php b/Entity/ClientManager.php
@@ -25,24 +25,14 @@ class ClientManager extends BaseClientManager
      */
     protected $em;
 
-    /**
-     * @var EntityRepository
-     */
-    protected $repository;
-
     /**
      * @var string
      */
     protected $class;
 
     public function __construct(EntityManagerInterface $em, $class)
     {
-        // NOTE: bug in Doctrine, hinting EntityRepository|ObjectRepository when only EntityRepository is expected
-        /** @var EntityRepository $repository */
-        $repository = $em->getRepository($class);
-
         $this->em = $em;
-        $this->repository = $repository;
         $this->class = $class;
     }
 
@@ -59,7 +49,7 @@ public function getClass()
      */
     public function findClientBy(array $criteria)
     {
-        return $this->repository->findOneBy($criteria);
+        return $this->getRepository()->findOneBy($criteria);
     }
 
     /**
@@ -79,4 +69,11 @@ public function deleteClient(ClientInterface $client)
         $this->em->remove($client);
         $this->em->flush();
     }
+
+    private function getRepository(): EntityRepository
+    {
+        $repository = $this->em->getRepository($this->class);
+
+        return $repository;
+    }
 }
diff --git a/Entity/TokenManager.php b/Entity/TokenManager.php
@@ -85,15 +85,9 @@ public function deleteExpired()
         return $qb->getQuery()->execute();
     }
 
-    /**
-     * @return EntityRepository
-     */
-    protected function getRepository(): EntityRepository
+    private function getRepository(): EntityRepository
     {
         $repository = $this->em->getRepository($this->class);
-        if (!($repository instanceof EntityRepository)) {
-            throw new \RuntimeException('EntityRepository needed');
-        }
 
         return $repository;
     }

diff --git a/Tests/Entity/ClientManagerTest.php b/Tests/Entity/ClientManagerTest.php
@@ -58,7 +58,6 @@ public function setUp()
         $this->className = 'RandomClassName'.\random_bytes(5);
 
         $this->entityManager
-            ->expects($this->once())
             ->method('getRepository')
             ->with($this->className)
             ->willReturn($this->repository)
@@ -72,7 +71,6 @@ public function setUp()
     public function testConstructWillSetParameters()
     {
         $this->assertAttributeSame($this->entityManager, 'em', $this->instance);
-        $this->assertAttributeSame($this->repository, 'repository', $this->instance);
         $this->assertAttributeSame($this->className, 'class', $this->instance);
     }
 

diff --git a/Tests/Entity/TokenManagerTest.php b/Tests/Entity/TokenManagerTest.php
@@ -227,29 +227,4 @@ public function testDeleteExpired()
 
         $this->assertSame($randomResult, $this->instance->deleteExpired());
     }
-
-    public function testExceptionWithObjectRepository()
-    {
-        $this->repository = $this->getMockBuilder(ObjectRepository::class)
-            ->disableOriginalConstructor()
-            ->getMock()
-        ;
-
-        $this->entityManager = $this->getMockBuilder(EntityManager::class)
-            ->disableOriginalConstructor()
-            ->getMock()
-        ;
-
-        $this->entityManager
-            ->expects($this->once())
-            ->method('getRepository')
-            ->with($this->className)
-            ->willReturn($this->repository)
-        ;
-
-        $this->instance = new TokenManager($this->entityManager, $this->className);
-
-        $this->expectException(\RuntimeException::class);
-        $this->instance->findTokenBy([]);
-    }
 }