-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean integration of CouchDB #524
base: master
Are you sure you want to change the base?
Changes from 1 commit
0f7648f
9438cfb
2e9c064
8261b6a
214452f
7fc056d
a57222f
a9fc0a8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,8 @@ | |
"friendsofsymfony/oauth2-php": "~1.1", | ||
"symfony/framework-bundle": "~3.0|^4.0", | ||
"symfony/security-bundle": "~3.0|^4.0", | ||
"symfony/dependency-injection": "^2.8|~3.0|^4.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why removing this? |
||
"symfony/dependency-injection": "^2.8|~3.0|^4.0", | ||
"alcaeus/mongo-php-adapter": "^1.1" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is related to Mongo ODM, don't need it. |
||
}, | ||
"require-dev": { | ||
"symfony/class-loader": "~3.0|^4.0", | ||
|
@@ -34,6 +35,9 @@ | |
"doctrine/mongodb-odm": "~1.0", | ||
"doctrine/doctrine-bundle": "~1.0", | ||
"doctrine/orm": "~2.2", | ||
"doctrine/couchdb": "1.0.x-dev", | ||
"doctrine/couchdb-odm": "dev-master", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TBH this is the problem I'm seeing here, I'd like for them to do a release before we integrate it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Totally agree, CouchDB 2.1 was just release so I hope some people can update this... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, nobody is working on couchdb-odm at the moment. I wouldn't count on a stable release anytime soon. With that in mind, I'm not sure if we should add integration for CouchDB at this time. |
||
"doctrine/couchdb-odm-bundle": "@dev", | ||
"phpunit/phpunit": "~4.8|~5.0" | ||
}, | ||
"suggest": { | ||
|
@@ -52,5 +56,10 @@ | |
"branch-alias": { | ||
"dev-master": "2.0-dev" | ||
} | ||
}, | ||
"config": { | ||
"platform": { | ||
"ext-mongo": "1.6.16" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also for Mongo ODM, remove. |
||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't the existing code work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CouchDB work with JS view to make request, I don't have function to request and check date, I have to find a way to make this view and import this view in CouchDB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but ODM abstracts all of it away. My questions was: why can't existing code (or something very similar to it) do the same task.