This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
adds option to set custom at_exp cookie name #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeLo123
requested review from
mooreds,
dmackinn,
BriDavidson and
david-chalk
BriDavidson
previously approved these changes
Feb 21, 2024
dmackinn
previously approved these changes
Feb 21, 2024
david-chalk
dismissed stale reviews from dmackinn and BriDavidson
via
c4688a9
dmackinn
approved these changes
Feb 22, 2024
david-chalk
approved these changes
Feb 22, 2024
BriDavidson
approved these changes
Feb 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR and why do we need it?
A small enhancement described by issue #57. Users of the SDK should be able to set a custom cookie name for the access token expiration cookie (defaults to
app.at_exp-- which is what is used by the FA hosted server)Pre-Merge Checklist (if applicable)