Begin breaking apart gam.py into logical pieces #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start with one of the deepest parts of the stack, Google API request execution calls and associated errors. Critical information printing functions and application control logic are also broken out into their own components. This change also adds unit tests for migrated content and makes code more PEP8 compliant. This commit starts work on GAM-team#147
|
@jay0lee I won't claim to be familiar with the build environment you're using, so if there's anywhere that these new files needed to be added to a build config, let me know. |
|
@ejochman if you want to improve GAM, I'd start instead with the https://github.com/taers232c/GAMADV-XTD3 source. It is a better codebase (proper exit statuses, support for more features, python3 compatible) and tends to get new features earlier than GAM itself, while maintaining command line compatibility. |
|
This looks like a good start, for the unit tests you added, can we also add them to .travis.yaml so they are executed on all changes? |
Makes tests compatible with Python 3.5. assert_called_once() is only available in Python 3.6+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start with one of the deepest parts of the stack, Google API request execution calls and associated errors. Critical information printing functions and application control logic are also broken out into their own components.
This change also adds unit tests for migrated content and makes code more PEP8 compliant.
This commit starts work on #147