Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GMAO_perllib into its own repo #361

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove GMAO_perllib into its own repo #361

wants to merge 1 commit into from

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Nov 21, 2024 •
edited
Loading

This PR removes GMAO_perllib into its own repo. Done via RepoExtractor as:

./extract_repo.bash -r "GMAO_Shared" -d "GMAO_perllib" --newrepo "GMAO_perllib" --create-repo --push

I also brought over one branch for @rtodling, feature/rtodling/move_acquire4jedi.

Requires GEOS-ESM/GEOSgcm#850

@mathomp4 mathomp4 requested review from a team as code owners November 21, 2024 22:10
@github-actions GitHub Actions
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@mathomp4 mathomp4 mentioned this pull request Nov 21, 2024
Draft
@mathomp4 mathomp4 added Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs 0 diff structural Structural changes to repository that are zero-diff labels Nov 21, 2024
@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, 0 diff structural

2 similar comments
@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, 0 diff structural

@github-actions GitHub Actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, 0 diff structural

@mathomp4 mathomp4 marked this pull request as draft November 21, 2024 22:13
@mathomp4 mathomp4 mentioned this pull request Nov 21, 2024
Open
rtodling
rtodling approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From browsing it looks ok ... I will test this out after this goes through and I can test in ADAS mode . thanks

@rtodling rtodling marked this pull request as ready for review November 25, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtodling rtodling rtodling approved these changes

Assignees
No one assigned
Labels
0 diff structural Structural changes to repository that are zero-diff Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @rtodling