[347] Refactor tests to remove hardcoded rupture sets #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voj
changed the title
voj
force-pushed
the
chore/347-update-tests
branch
from
f76388a to
90445b4
Compare
chrisdicaprio
approved these changes
Dec 5, 2024
| @@ -215,7 +215,6 @@ public static class GridHazards { | |||
| public static void main(String[] args) throws DocumentException, IOException { | |||
|
|
|||
| NZSHM22_HazardCalculatorBuilder builder = new NZSHM22_HazardCalculatorBuilder(); | |||
There was a problem hiding this comment.
why don't you need to set a solution file anymore? or maybe a better question is why did you need to set one before?
There was a problem hiding this comment.
We still need a solution file, this is now broken. I'll uncomment the next line. Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #347
This PR removes most uses of hard-coded alpine-vernon rupture sets or solutions.
These changes have brought a bug in our hazard calculations to light: #355 Once this issue is fixed, the last usage of an alpine-vernon solution can be removed.
There is a small number of other hard-coded files remaining in tests, and these can be removed in a separate PR. This one is already big enough.
General changes in this PR: