-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping pydantic >= 2.0.0 #247
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: fiskrt.
|
dfd667f
to
241fbf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, few comments.
Can we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem:
--> Goal: Bump pydantic
Refactor is largely done but not all tests are passing yet.
Without the hacky line
we get:
It would be best to find a way to have a non-empty parameter list here.