Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed front end bug with timer pauses through deleting dependency ont… #204

Merged

Conversation

BeanyBeans
Copy link
Contributor

Fixed front end bug with timer pauses

Issue Number(s): #201

Fixes the issue of the timer pauses when pressing next for the reading/writing sections

Checklist

  • Explore and understand the relevant codebase
  • Time pausing bug is fixed

Critical Changes / Notes

  • Deleted onTimeComplete dependency in the second useEffect in ProgressBar

Related PRs

Testing

Ran through the reading and writing section clicking next, checking for timer pause issues and any related issues

@BeanyBeans BeanyBeans requested a review from samarth52 February 5, 2024 00:46
@BeanyBeans BeanyBeans linked an issue Feb 5, 2024 that may be closed by this pull request
2 tasks
Copy link

github-actions bot commented Feb 5, 2024

🚀 Expo preview is ready!

  • Project → brain-exercise
  • Platforms → android, ios
  • Scheme → myscheme
  • Runtime Version → 1.0.0
  • More info

Learn more about 𝝠 Expo Github Action

Copy link
Contributor

@samarth52 samarth52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@samarth52 samarth52 merged commit 9e8f63c into develop Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Bug Fix: Timer Pauses on Button Clicks
2 participants