Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Pin types-requests version #208

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Python: Pin types-requests version #208

merged 2 commits into from
Apr 12, 2024

Conversation

RyanGlScott
Copy link
Contributor

Fixes #207.

@RyanGlScott
Copy link
Contributor Author

Having fixed #207, the CI fails for an entirely different reason when cabal picks a build plan. Some investigation reveals that this ultimately ties back to basement not being buildable on pre-8.10 versions of GHC. To make life easier, I think I am going to just drop the GHC 8.8 build, as it's quite old at this point (and well beyond our typical 3-latest-versions-of-GHC support window).

The `basement` library cannot easily be built with pre-8.10 versions of GHC
nowadays, which leads to `cabal` picking failing build plans when attempting to
build `argo` with GHC 8.8. Let's just drop the 8.8 build.
Copy link
Contributor

@mccleeary-galois mccleeary-galois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we were going to need to change this as well. LGTM.

@RyanGlScott RyanGlScott merged commit 59823e8 into master Apr 12, 2024
6 checks passed
@RyanGlScott RyanGlScott deleted the T207 branch April 12, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure due to mypy --install-types not freezing dependencies
2 participants