Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backoffice dashboard #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

jramirezd
Copy link

@jramirezd jramirezd commented Oct 14, 2020

Description

Initial backoffice estructure proposal width:
[Next.js]
https://nextjs.org

[TypeScript]
https://www.typescriptlang.org

[SASS/SCSS]
https://sass-lang.com

[Styled Components]
https://styled-components.com

[Jest]
https://jestjs.io

[ESLint]
https://eslint.org/

[Prettier]
https://prettier.io/.

To test Boilerplate:
Download repo: https://github.com/jramirezd/anem-per-feina-backoffice.

  • Make install.
  • Make start.

@XaviTorello XaviTorello requested review from d-asensio, XaviTorello and a team October 14, 2020 13:29
Copy link

@victormartingarcia victormartingarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a minor prettier problem (potentially only on my side).

It would be awesome if you can add on README.md the recommended plugins for vscode ;)

pages/ssr.tsx Outdated
<h1>This page was server-side rendered (SSR)!</h1>
<Paragraph>This is always built when requested.</Paragraph>
<Paragraph>
The button starts as if having been clicked {randomPositiveInt} time

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's just me, but my prettier complains about this line (making tests fail):

error Insert {'·'}⏎············· prettier/prettier

It gets fixed adding a whitespace like this:

The button starts as if having been clicked {randomPositiveInt}{' '}time

@d-asensio d-asensio removed their request for review August 19, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants