Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test that checks that we do not regress re/ non-standard column names #443

Merged
merged 2 commits into from
May 27, 2024

Conversation

Taepper
Copy link
Collaborator

@Taepper Taepper commented May 24, 2024

resolves #

Summary

A bug was mentioned by @corneliusroemer a while back that SILO crashed on certain numeric sequence names. When I fixed this I missed to implement a test, which guarantees that we do not regress in this regard. This is that missed test

PR Checklist

- [ ] All necessary documentation has been adapted or there is an issue to do so.
- [ ] The implemented feature is covered by an appropriate test.

@Taepper Taepper force-pushed the test-numeric-column-names branch from 9326f7a to 251d9cd Compare May 27, 2024 09:24
@Taepper Taepper merged commit d0bcb15 into main May 27, 2024
9 checks passed
@Taepper Taepper deleted the test-numeric-column-names branch May 27, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants