Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow that comments changelog preview on PRs #493

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

fengelniederhammer
Copy link
Contributor

Summary

PR Checklist

  • [ ] All necessary documentation has been adapted or there is an issue to do so.
  • [ ] The implemented feature is covered by an appropriate test.

@GenSpectrum GenSpectrum deleted a comment from github-actions bot Jun 18, 2024
@fengelniederhammer fengelniederhammer marked this pull request as ready for review June 18, 2024 21:00
@fengelniederhammer
Copy link
Contributor Author

See GenSpectrum/LAPIS#840 for a similar PR that has a current change that causes a comment.

@Taepper
Copy link
Collaborator

Taepper commented Jun 18, 2024

Shouldn't this already comment that preview on this PR?

@fengelniederhammer
Copy link
Contributor Author

Shouldn't this already comment that preview on this PR?

There are currently no changes that would trigger a version bump (that's also why there is currently no open version PR in SILO)

@Taepper
Copy link
Collaborator

Taepper commented Jun 19, 2024

Ah, I thought this was meant to show, what the change log would look like after the current PR is merged

@fengelniederhammer
Copy link
Contributor Author

Ah, I thought this was meant to show, what the change log would look like after the current PR is merged

Exactly, that's what it does. But this PR doesn't introduce any relevant changes. Maybe the feat in the PR title confused you, I'll remove it - it's a leftover from me testing it.

@fengelniederhammer fengelniederhammer changed the title feat: add workflow that comments changelog preview on PRs ci: add workflow that comments changelog preview on PRs Jun 19, 2024
@Taepper
Copy link
Collaborator

Taepper commented Jun 19, 2024

Ah, yes that is precisely it! Thanks!

@fengelniederhammer fengelniederhammer self-assigned this Jun 19, 2024
@fengelniederhammer fengelniederhammer merged commit deebf78 into main Jun 19, 2024
10 checks passed
@fengelniederhammer fengelniederhammer deleted the changelogPreview branch June 19, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants