Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): extract modal component #619

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

fengelniederhammer
Copy link
Collaborator

Summary

Screenshot

PR Checklist

- [ ] All necessary documentation has been adapted.

  • The implemented feature is covered by an appropriate test.

@fengelniederhammer fengelniederhammer added the components Regarding the components label Dec 18, 2024
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 9:30am

Copy link
Contributor

This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.

Note that this might contain changes that are on main, but not yet released.

Changelog:

0.11.2 (2024-12-18)

Features

  • components: gs-sequences-by-location: show how many sequences were matched on locations in map view (#616) (2eb42ad), closes #614

Bug Fixes

  • components: set default of enableMapNavigation to false (#610) (bb7bae4)

Copy link
Collaborator

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

components/src/preact/components/modal.tsx Show resolved Hide resolved
@fengelniederhammer fengelniederhammer merged commit 95358f9 into main Dec 19, 2024
7 checks passed
@fengelniederhammer fengelniederhammer deleted the extractModal branch December 19, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components Regarding the components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants