-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): improve design of location filter #622
feat(components): improve design of location filter #622
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cd93afb
to
894f7fa
Compare
894f7fa
to
fd73164
Compare
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.11.4 (2025-01-07)FeaturesBug Fixes
|
When the user clears the selection using the "x" button or when the user deletes all characters and then blurs, a new event is fired with an empty filter. When the user clears single charcters, but does not select a new location, and then blurs, the selection is put back to the original value. |
css not working in web components
@JonasKellerer - I love that you were able to put the x before the dropdown button - is this because you imported the style sheet? Do you know if its possible to modify the location of the label with a style sheet as well? e.g. in #633 Also if you have time it would also be great if you could explain to me how you are using react in the webcomponents as Fabian told me this wasn't possible |
a273cee
to
6b7292f
Compare
6b7292f
to
f193114
Compare
f193114
to
5550de6
Compare
5550de6
to
b5eff9a
Compare
Closing in favor of #638, which is the updated version using downshift. |
Resolves: #267
Summary
This is a draft of how an improved design of the location filter could look like with "react-select". It provides a simple api to create searchable select fields, which is less code to maintain.
Open points are:
I will now look into downshift and see if this will be better. I also looked into headless-ui, but this is even more code to maintain, so I would only use it, if we have to.
Screenshot
Bildschirmaufzeichnung.vom.19.12.2024.09.11.13.webm
PR Checklist