-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
609 filter autocomplete options of location filter text input and location filter #666
609 filter autocomplete options of location filter text input and location filter #666
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.13.0 (2025-01-21)⚠ BREAKING CHANGES
Features
Bug Fixes
Code Refactoring |
00a9074
to
f3a57f5
Compare
7a36137
to
4aef6a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, maybe the docs can be improved a little (for all components)
wupps I realized while using this in dashboards that we need to pass in the lapisFilter as a dependency or else lapisFilter changes will not cause a rerender and defeat the point of this change, I used this in: GenSpectrum/dashboards#486 |
277c82b
to
622f469
Compare
469f475
to
b22b710
Compare
622f469
to
9a193fc
Compare
resolves #609
Summary
Adds the option to provide a lapis filter to the text-input, location-filter and lineage-filter. The filter is applied to limit the select options.
Screenshot
PR Checklist