Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

609 filter autocomplete options of location filter text input and location filter #666

Conversation

JonasKellerer
Copy link
Collaborator

resolves #609

Summary

Adds the option to provide a lapis filter to the text-input, location-filter and lineage-filter. The filter is applied to limit the select options.

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 7:23am

Copy link
Contributor

github-actions bot commented Jan 20, 2025

This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.

Note that this might contain changes that are on main, but not yet released.

Changelog:

0.13.0 (2025-01-21)

⚠ BREAKING CHANGES

  • components: Rename initialValue to value for gs-lineage-filter
  • components: Rename initialValue to value for text input

Features

  • components: add lapis filter to lineage filter (c657146), closes #609
  • components: add lapis filter to location filter (74eb514), closes #609
  • components: add lapis filter to text input (0a13a94), closes #609
  • components: gs-lineage-filter: rename initialValue to value (1ff38e4)
  • components: gs-lineage-filter: use downshift for selector (e66d526), closes #654
  • components: let users know that they can not select anything in filter (07eedcf)

Bug Fixes

  • components: add lapisFilter as dependency so that filter is reloaded upon change (9a193fc)

Code Refactoring

  • components: extract downshift combobox from location filter and text input (dfe105e), closes #660

Copy link
Collaborator

@anna-parker anna-parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe the docs can be improved a little (for all components)

@anna-parker
Copy link
Collaborator

wupps I realized while using this in dashboards that we need to pass in the lapisFilter as a dependency or else lapisFilter changes will not cause a rerender and defeat the point of this change, I used this in: GenSpectrum/dashboards#486

@anna-parker anna-parker force-pushed the 609-filter-autocomplete-options-of-location-filter-text-input-and-location-filter branch from 277c82b to 622f469 Compare January 20, 2025 21:38
@JonasKellerer JonasKellerer force-pushed the 654-gs-lineage-filter-add-button-to-delete-current-input branch 2 times, most recently from 469f475 to b22b710 Compare January 21, 2025 06:58
Base automatically changed from 654-gs-lineage-filter-add-button-to-delete-current-input to main January 21, 2025 07:20
@JonasKellerer JonasKellerer force-pushed the 609-filter-autocomplete-options-of-location-filter-text-input-and-location-filter branch from 622f469 to 9a193fc Compare January 21, 2025 07:20
@JonasKellerer JonasKellerer merged commit bc08949 into main Jan 21, 2025
7 checks passed
@JonasKellerer JonasKellerer deleted the 609-filter-autocomplete-options-of-location-filter-text-input-and-location-filter branch January 21, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter autocomplete options of location filter, text input and location filter
3 participants