[pull] main from geonetwork:main #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
The column is added automatically by Hibernate when GeoNetwork starts. Removing it from the SQL because it makes the process to fail with ``` Duplicate column name "ICON"; SQL statement: ALTER TABLE public.spg_page ADD icon varchar NUL [42121-212] ``` Related to #7536.
Fix some incorrect comments Remove class prefix as it was not required. Added missing license.
These services aren't available anymore. This commit remove the implementing classes from GeoNetwork source code. Services removed: * `profiles.Get` * `util.ping` * `RegExpReplace` * `db.select` * `http.Get` * `session.Put`
* Upgrade guidance for geonetwork 3 users - Includes mitigation guidance for removed serivces - housekeeping: Address mkdocs warnings with due to changing emoji library - change maven build to use --strict flag to prevent mkdoc regressions Signed-off-by: Jody Garnett <[email protected]> * Update docs/manual/docs/maintainer-guide/updating/index.md * Update docs/manual/docs/maintainer-guide/updating/index.md * Update docs/manual/docs/maintainer-guide/updating/index.md * Update docs/manual/docs/maintainer-guide/updating/index.md * Update docs/manual/docs/maintainer-guide/updating/index.md * Update doc typos --------- Signed-off-by: Jody Garnett <[email protected]> Co-authored-by: Jose García <[email protected]>
Affected API calls: * http://localhost:8080/geonetwork/srv/api/records/720ceda7-a9ea-4bbe-896a-04925c44a7f0/formatters/xyz * http://localhost:8080/geonetwork/srv/api/records/720ceda7-a9ea-4bbe-896a-04925c44a7f0/related?type=thumbnails&type=onlines For testing, add a record with 2 online resources. Add withheld attribute to one of them, call the related API. Sometimes 1 or 2 links are returned (it does not happen always, but usually if accessing the same API call with a browser and Curl using the same session the problem can be observed). A variable was set using ThreadLocal which looks to be the cause of this. It was noticed while opening the editor not always listing all distribution links. The Formatter API has a `hide_withheld` parameter to hide with held elements even if the user is allowed to see them. The application is not using this parameter, and opening an incognito window can be used to check if with held elements are properly removed. This change propose to remove the ThreadLocal variable and only rely on user session and edits rights of the current user to hide or not with held elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )