refactor: Use ProxyCreate
to remove setTimeout
#72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #67 made it so that the value of
this
is irrelevant after thenewTarget
check, this moves the proxy construction into aProxyCreate
helper function, which is based on theProxyCreate
abstract operation, but takes an additionalallowRevocation
parameter, which is used to conditionally create therevoke
function only when necessary, which also follows the spec more closely.It also fixes the issue listed in:
proxy-polyfill/src/proxy.js
Lines 86 to 88 in 60b4e5e