Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: truncate monitoringdashboard CRD to fit into cc operator check #2224

Merged

Conversation

yuwenma
Copy link
Collaborator

@yuwenma yuwenma commented Jul 3, 2024

I tried the new CRD size in the operator and it passes the TestConfigConnectorE2E check.

related to #2217

Capture some solutions to the root cause:

  1. Switch the cc operator's default applier to use server-side-apply. This requires upstream change to k-d-p feat: Enable server-side-apply on direct applier kubernetes-sigs/kubebuilder-declarative-pattern#399
  2. Switch the cc operator to use the ApplysetApplier (use ssa already). This requires not setting the metadata.managedFields. But the DCL/TF based controllers already have many handlings around managedFields. So this may not be a good option.
  3. Turn on the operator check in presubmit to capture this issue earlier.

@yuwenma yuwenma changed the title fix: truncate monitoringdashboard CRD to fit into cc operator annotat… fix: truncate monitoringdashboard CRD to fit into cc operator annotation Jul 3, 2024
@yuwenma yuwenma changed the title fix: truncate monitoringdashboard CRD to fit into cc operator annotation fix: truncate monitoringdashboard CRD to fit into cc operator check Jul 3, 2024
@justinsb
Copy link
Collaborator

justinsb commented Jul 3, 2024

I was imagining we just remove all the descriptions with a transformation here:

go run ./scripts/crd-tools reflow-descriptions --dir apis/config/crd/
, but I do agree that a lot of the information here is superfluous.

/approve
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 3, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Collaborator

justinsb commented Jul 3, 2024

(We can always revert this PR and try the other approach in 1.121)

@google-oss-prow google-oss-prow bot merged commit 5f01d8a into GoogleCloudPlatform:master Jul 3, 2024
13 checks passed
@yuwenma yuwenma added this to the 1.120 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants