Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (appengine) update region appengine to gae #3958

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix: (appengine) update region appengine to gae #3958

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
65c3c8e
fix: (data_catalog) delete deprecated region tag in createFilesettEnt…
hivanalejandro Jan 22, 2025
8e2456d
fix: (data_catalog) delete deprecated region tag in quickstart/create…
hivanalejandro Jan 22, 2025
e8bf288
fix: (appengine) update region tag in appengine/websockets/app.yaml
hivanalejandro Jan 23, 2025
01ba935
fix linting issues
hivanalejandro Jan 23, 2025
9ee1b13
added license header to appengine/websockets/app.yaml file
hivanalejandro Jan 23, 2025
3369b83
update license header to appengine/websockets/app.yaml file
hivanalejandro Jan 23, 2025
f48277c
fix region tag name
hivanalejandro Jan 23, 2025
18bdc26
fix region tag name
hivanalejandro Jan 23, 2025
61a491a
Merge branch 'main' into hivanalejandro-migrate-region-step1-391843837
iennae Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions appengine/websockets/app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# [START appengine_websockets_yaml]
# [START gae_websockets_yaml]
runtime: nodejs
env: flex

Expand All @@ -10,5 +10,5 @@ manual_scaling:

network:
session_affinity: true
# [END appengine_websockets_yaml]
# [END gae_websockets_yaml]

2 changes: 0 additions & 2 deletions datacatalog/cloud-client/createFilesetEntry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const main = async (
entryId
) => {
// [START data_catalog_create_fileset]
// [START datacatalog_create_fileset_tag]
// -------------------------------
// Import required modules.
// -------------------------------
Expand Down Expand Up @@ -101,7 +100,6 @@ const main = async (
const [response] = await datacatalog.createEntry(request);

console.log(response);
// [END datacatalog_create_fileset_tag]
// [END data_catalog_create_fileset]
};

Expand Down
2 changes: 0 additions & 2 deletions datacatalog/quickstart/createFilesetEntry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const main = async (
entryId
) => {
// [START data_catalog_create_fileset_quickstart]
// [START datacatalog_create_fileset_quickstart_tag]
// -------------------------------
// Import required modules.
// -------------------------------
Expand Down Expand Up @@ -125,7 +124,6 @@ const main = async (

console.log(response);
};
// [END datacatalog_create_fileset_quickstart_tag]
// [END data_catalog_create_fileset_quickstart]

// node createFilesetEntry.js <projectId> <entryGroupId> <entryId>
Expand Down
Loading