feat: log stacktrace (#3418)

* feat: log stacktrace * use string writer * reformat * modify test * log exception along the message
GoogleCloudPlatform · Dec 16, 2024 · cebcbed · cebcbed
1 parent 765975d
commit cebcbed
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.../java/com/google/cloud/spring/pubsub/integration/inbound/PubSubInboundChannelAdapter.java b/.../java/com/google/cloud/spring/pubsub/integration/inbound/PubSubInboundChannelAdapter.java
@@ -175,9 +175,9 @@ private void logWarning(
     // so we explicitly log failure messages.
     // See https://github.com/spring-projects/spring-framework/issues/25162 for more info.
     if (re instanceof MessageDeliveryException messageDeliveryException) {
-      LOGGER.warn(messageDeliveryException.getFailedMessage());
+      LOGGER.warn(messageDeliveryException.getFailedMessage(), messageDeliveryException);
     } else {
-      LOGGER.warn(re.getMessage());
+      LOGGER.warn(re.getMessage(), re);
     }
   }
 

diff --git a/.../com/google/cloud/spring/pubsub/integration/inbound/PubSubInboundChannelAdapterTests.java b/.../com/google/cloud/spring/pubsub/integration/inbound/PubSubInboundChannelAdapterTests.java
@@ -166,7 +166,10 @@ void testAckModeAuto_nacksWhenDownstreamProcessingFailsWhenContextShutdown(Captu
     verify(mockAcknowledgeableMessage, times(0)).ack();
 
     // original message handling exception
-    assertThat(capturedOutput).contains("failed; message nacked automatically").contains(EXCEPTION_MESSAGE);
+    assertThat(capturedOutput)
+        .contains("failed; message nacked automatically")
+        .contains(EXCEPTION_MESSAGE)
+        .contains("Caused by");
   }
 
   @Test