WIP: Fix python #135
WIP: Fix python #135
Conversation
There was a problem hiding this comment.
@TinoDidriksen you should address/remove the TODO comment in python/CMakeLists.txt before merging.
Also, I highly recommend Squashing the commits because I have many useless commits from trying to debug the Github Action when it was working locally.
| @@ -29,8 +30,8 @@ add_custom_target(wrapper ALL | |||
| ) | |||
|
|
|||
| if(NOT PYTHON_INSTALL_PARAMS) | |||
| set(PYTHON_INSTALL_PARAMS "--prefix=${CMAKE_INSTALL_PREFIX} --root=\$ENV{DESTDIR}/") | |||
| set(PYTHON_INSTALL_PARAMS "--no-index --find-links=dist/") # TODO removing --prefix=${CMAKE_INSTALL_PREFIX} --root=\$ENV{DESTDIR}/ probably has downstream effects | |||
There was a problem hiding this comment.
Note that I removed the arguments for --prefix and --root to simplify the Github Action test of the python module. I'm guessing this affects downstream scripts for publishing debian or nightly builds. I would recommend basing downstream scripts on the wheel file created in cg3/python/dist/, but another option is to expand python's search path in the GH Action to find the install.
|
Finally had time to try this out. It only builds a wheel. But I don't understand what changes cause that. Wheels and distro packages are two orthogonal worlds. Wheels belong to So, the changes are ok for wheel building, but unfortunately wrong for distro building. This repo must continue using But it might make sense to split it off as a cg3-python repo. |
… shared library instead of rebuilding; Consolidate source file list
… shared library instead of rebuilding; Consolidate source file list
… shared library instead of rebuilding; Consolidate source file list
TinoDidriksen
force-pushed
the
main
branch
2 times, most recently
from
d4d7d27 to
3ddbcba
Compare
… shared library instead of rebuilding; Consolidate source file list
No description provided.