-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add IF EXISTS
for DROP
#123
Conversation
Please run |
Oh yes. I thought the generated code will be did by the bot. |
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Can you make a rebase to solve conflicts? Thank you!
Sorry, it has some conflict and can't rebase. BTW, I don't have complete compile chain like golang and cmake in my mac. |
Our makefile utilizes docker to generate code, only a docker env is required |
Yes, but my personal mac's docker client is connected to my company's internal docker server due to the limited disk space. And I found the golang dependency is still needed. |
Whoops... |
For GreptimeTeam/greptimedb#2794
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add the
drop_if_exists
to match the mysql statement fordrop
Checklist
Refer to a related PR or issue link (optional)