Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for region migration procedure #2857

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Dec 1, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Refactors the State of the RegionMigration.
  2. Add some basic region migration tests.

And some remaining tests will be added in the next PR.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2700

@WenyXu WenyXu self-assigned this Dec 1, 2023
@WenyXu WenyXu mentioned this pull request Dec 1, 2023
39 tasks
@WenyXu WenyXu force-pushed the test/region-migration-rebased branch 2 times, most recently from 8c9ee11 to 5c37097 Compare December 4, 2023 05:32
@WenyXu WenyXu marked this pull request as ready for review December 4, 2023 05:33
@WenyXu WenyXu marked this pull request as draft December 4, 2023 05:43
@WenyXu WenyXu force-pushed the test/region-migration-rebased branch from 5c37097 to ddb6e60 Compare December 4, 2023 09:21
@WenyXu WenyXu force-pushed the test/region-migration-rebased branch from ddb6e60 to 18ad8d8 Compare December 4, 2023 09:22
@WenyXu WenyXu marked this pull request as ready for review December 4, 2023 09:22
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #2857 (1a48683) into develop (7a14db6) will decrease coverage by 0.38%.
Report is 14 commits behind head on develop.
The diff coverage is 97.16%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2857      +/-   ##
===========================================
- Coverage    84.78%   84.40%   -0.38%     
===========================================
  Files          740      749       +9     
  Lines       116244   118343    +2099     
===========================================
+ Hits         98554    99884    +1330     
- Misses       17690    18459     +769     

@WenyXu
Copy link
Member Author

WenyXu commented Dec 7, 2023

@fengjiachun @MichaelScofield PTAL

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Dec 8, 2023
Merged via the queue into GreptimeTeam:develop with commit 5a99f09 Dec 8, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants