feat(mito): add skip_wal_replay option to OpenRegionRequest
#2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2955 +/- ##
===========================================
- Coverage 85.80% 85.28% -0.52%
===========================================
Files 767 767
Lines 123633 123745 +112
===========================================
- Hits 106086 105542 -544
- Misses 17547 18203 +656 |
evenyag
reviewed
Dec 19, 2023
WenyXu
changed the title
skip_replay_wal option to OpenRegionRequestskip_wal_replay option to OpenRegionRequest
WenyXu
force-pushed
the
feat/open-region-skip-replay-wal
branch
from
04fb774 to
9920efd
Compare
WenyXu
force-pushed
the
feat/open-region-skip-replay-wal
branch
from
9920efd to
bd54869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
The region migration will open the candidate region first(the engine opens the region without replaying the WAL, for now), then upgrade the candidate region to the leader region(catching up on the latest manifest and replaying the WAL).
BTW, the follower region does not automatically synchronize with the changes made to the leader region. The duration of the write-stop window during region migration will be reduced once this feature is implemented.
Checklist
Refer to a related PR or issue link (optional)
#2700