-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement iter for the new memtable #3373
Conversation
4c23cb6
to
82084ee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3373 +/- ##
==========================================
- Coverage 85.60% 85.21% -0.40%
==========================================
Files 893 893
Lines 146815 147210 +395
==========================================
- Hits 125676 125438 -238
- Misses 21139 21772 +633 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR mainly implements the
iter()
method for the new memtable.iter()
method returns aTreeIter
to iterate partitionsTreeIter
read partitions one by onePartitionReader
PartitionReader
mergesDataBatches
from differentShardReaderImpls
and theShardBuilderReaders
ShardReader
mergesDataBatches
from different data parts.Unresolved problem:
DedupReader
Checklist
Refer to a related PR or issue link (optional)