-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement dedup for the new memtable and expose the config #3377
Conversation
860aa40
to
9452519
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
==========================================
- Coverage 85.65% 85.26% -0.40%
==========================================
Files 893 893
Lines 147210 147247 +37
==========================================
- Hits 126099 125543 -556
- Misses 21111 21704 +593 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements dedup for the new memtable. It adds a config to the
MitoConfig
to enable the new table.This PR contains some bug fixes while testing the new memtable.
PartitionReader
doesn't prune the first entry its underlying source returns.KeyValue
returns incorrect field num.Checklist
Refer to a related PR or issue link (optional)