Config #245
Merged
Config #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
reviewed
Dec 26, 2024
| for k in ("hs_endpoint", "hs_username", "hs_endpoint"): | ||
| if k not in Config._cfg: | ||
| Config._cfg[k] = None | ||
| if "bool_names" not in Config._cfg: |
There was a problem hiding this comment.
It looks like bool_names and complex_names are intended to let the application running HSDS customize what boolean and complex values are called.
Since this doesn't do anything right now and isn't related to this set of changes, I think it would be a good idea to bring this out until it's fully implemented
There was a problem hiding this comment.
That's valid, but I think I'll leave it in for compatibility. complex and bool types will be coming soon.
mattjala
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added h5pyd.get_config method.
Also: retain track_order behvior over file open/close