Integrate preprocess scripts #742
Merged
+715
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ChristosT! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2025-01-21 16:29:10 UTC |
ChristosT
force-pushed
the
integrate-preprocess-scripts
branch
3 times, most recently
from
993943a to
d2af8df
Compare
ChristosT
force-pushed
the
integrate-preprocess-scripts
branch
2 times, most recently
from
834ad77 to
57be82f
Compare
Using a list of tuples forces the dumper to add type annotations, while using a list of list avoid this issue.
Eiger should accept only one file provided via absolute_path while Dexelas series of files constructed using command line arguments
The latter is not a subset of the former. A new class is introduced Chess_Arguments that is a superset of both
Missing types found using mypy hexrd/preprocess/ --follow-imports=skip --disallow-untyped-defs mypy hexrd/cli/preprocess.py --follow-imports=skip --disallow-untyped-defs using mypy --version mypy 1.14.1 (compiled: yes)
Arguments set to None in argument profiles will be treated as required positional arguments. This behavior matches the original scripts.
ChristosT
force-pushed
the
integrate-preprocess-scripts
branch
from
57be82f to
274e1f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR integrates the preprocessor scripts into the main
hexrdexecutable via anew subcommand.Usage:
for now we have two profiles
{eiger,dexelas}. Each profile comes with its own flags.Adding a new profile boils down to creating a new class derived from
PP_Basethat holds the logic of the preprocessor seehexrd/preprocess/preprocessors.pyand creating a new profile that holds the cli flags which be done by deriving fromHexrdPPScript_Argumentsseehexrd/preprocess/profiles.py. The new profile will then become available as an option inhexrd preprocess.