Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove authorizer and external authorizer attributes used in test data #3214

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

maiyerlee
Copy link
Contributor

@maiyerlee maiyerlee commented Dec 12, 2024

What changed

Attributes were removed last summer. PR removes the remaining values used in test data.

Issue

#3213

How to test

All tests passing.

Screenshots

N/A

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

Links

slack 🧵

@maiyerlee maiyerlee marked this pull request as ready for review January 21, 2025 02:05
@maiyerlee maiyerlee changed the title refactor: remove authorizer and external authorizer attributes Remove authorizer and external authorizer attributes used in test data Jan 21, 2025
@maiyerlee maiyerlee linked an issue Jan 21, 2025 that may be closed by this pull request
Copy link
Contributor

@fpigeonjr fpigeonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@maiyerlee maiyerlee merged commit 820546c into main Jan 21, 2025
42 checks passed
@maiyerlee maiyerlee deleted the OPS-310/3213-remove_authorizer_test_data branch January 21, 2025 19:02
Copy link

🎉 This PR is included in version 1.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove authorizer and external authorizer attributes
4 participants