Create CAN History GET endpoint #3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajohnson90
requested review from
jonnalley,
johndeange,
fpigeonjr,
maiyerlee,
Santi-3rd and
weimiao67
10 tasks
fpigeonjr
reviewed
Jan 13, 2025
| class CANHistoryItemSchema(Schema): | ||
| id = fields.Integer(required=True) | ||
| can_id = fields.Integer(required=True) | ||
| ops_event_id = fields.Integer(required=True) |
There was a problem hiding this comment.
should we add/update the openAPI spec to match?
There was a problem hiding this comment.
I suppose it probably wouldn't hurt
johndeange
approved these changes
Jan 13, 2025
fpigeonjr
approved these changes
Jan 14, 2025
maiyerlee
approved these changes
Jan 16, 2025
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Creating /can-history endpoint so users can retrieve the history of all actions performed on can. Adding test data to the database so that the can history can be interacted with from the front end in dev environments before any can history events have been triggered.
Issue
OPS-3276
How to test
Run all tests
Definition of Done Checklist