Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fiscal year calculations #3289

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add fiscal year calculations #3289

wants to merge 2 commits into from

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Jan 10, 2025 •
edited
Loading

What changed

  • adds logic to display for all 5 fiscal years in the CAN Budget by FY Card

Issue

#310 #3232

How to test

Write out steps for how someone could test this PR against the acceptance criteria

Screenshots

image

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [-] Form validations updated

@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Jan 10, 2025
@fpigeonjr fpigeonjr marked this pull request as ready for review January 10, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnalley jonnalley Awaiting requested review from jonnalley

@johndeange johndeange Awaiting requested review from johndeange

@rajohnson90 rajohnson90 Awaiting requested review from rajohnson90

@maiyerlee maiyerlee Awaiting requested review from maiyerlee

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

@weimiao67 weimiao67 Awaiting requested review from weimiao67

At least 3 approving reviews are required to merge this pull request.

Assignees

@fpigeonjr fpigeonjr

@weimiao67 weimiao67

Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpigeonjr @weimiao67