Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove activeTab permission request #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

SabreCat
Copy link
Member

@SabreCat SabreCat commented Jul 1, 2022

We received this notice from the Chrome Web Store:

image

On a search, the critique looks accurate--while we use storage in various places, the only place activeTab appears is in the manifest.json. This PR removes the permission request from the manifest.

@cTheDragons
Copy link
Contributor

cTheDragons commented Oct 3, 2022

From my testing on Firefox 105.0.1 (64-bit) appears to be have been working.
The only issue is the version is not updated in the extensions or Readme file. (Had to do a lot of double checking to make sure we have the right one)

Tested:

  • Auto connect via the option at the top
  • Retrieving messages from a guild/tavern
  • Updated while chat is open
  • add a message in a guild
  • liking a message
  • removing a like
  • reporting a message
  • checking info of a player
  • Quick reply on name and avatar
  • Keyboard shortcut of ctrl-Enter works

All tested on default options but did open up on large text no avatar to confirm these options work too.

@cTheDragons
Copy link
Contributor

From my testing on 105.0.5151.0 (Developer Build) (64-bit) appears to be have been working.
Four Bugs:

  • Error reported by the plugin Manifest version 2 is deprecated, and support will be removed in 2023. See https://developer.chrome.com/blog/mv2-transition/ for more details.
  • Issue is the version is not updated in the extensions or Readme file. (Had to do a lot of double checking to make sure we have the right one)
  • The Snowman transformation does not show correctly however I believe this is an existing bug.
  • The Spooky transformation is not align correctly. However I believe this an existing bug.

Tested:

  • Auto connect via the option at the top
  • Retrieving messages from a guild/tavern
  • Updated while chat is open
  • add a message in a guild
  • liking a message
  • removing a like
  • reporting a message
  • checking info of a player
  • Quick reply on name and avatar
  • Keyboard shortcut of ctrl-Enter works
  • Images displayed in chat
  • Transformations show in the chat for flower, star, spooky. As noted above Snowman does not show. Spooky is also shown off centre.

All tested on default options but did open up on large text no avatar to confirm these options work too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants