ORCID fix: provide no element if the locale is not in ISO 639-1, fix …

…localized publication title
Hafsa-Naeem · Dec 11, 2024 · d4f1460 · d4f1460
1 parent 3c4bcbf
commit d4f1460
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/classes/orcid/OrcidReview.php b/classes/orcid/OrcidReview.php
@@ -103,7 +103,7 @@ private function build(): array
             $orcidReview['review-url'] = ['value' => $publicationUrl];
             $orcidReview['subject-type'] = 'journal-article';
             $orcidReview['subject-name'] = [
-                'title' => ['value' => $this->submission->getCurrentPublication()->getLocalizedData('title') ?? '']
+                'title' => ['value' => $this->submission->getCurrentPublication()->getLocalizedTitle($submissionLocale) ?? '']
             ];
 
             if (!empty($currentPublication->getDoi())) {
@@ -125,7 +125,10 @@ private function build(): array
         $allTitles = $currentPublication->getData('title');
         foreach ($allTitles as $locale => $title) {
             if ($locale !== $submissionLocale) {
-                $orcidReview['subject-name']['translated-title'] = ['value' => $title, 'language-code' => LocaleConversion::getIso1FromLocale($locale)];
+                $iso1Locale = LocaleConversion::getIso1FromLocale($locale);
+                if ($iso1Locale) {
+                    $orcidReview['subject-name']['translated-title'] = ['value' => $title, 'language-code' => $iso1Locale];
+                }
             }
         }