Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vkd3d: Clean up reporting and checking maximum descriptor counts. #2237

Conversation

doitsujin
Copy link
Collaborator

@doitsujin doitsujin commented Dec 2, 2024

Fallout from the Stalker 2 thing. Unclear if we want to add validation since ANV worked around the problem for now, but I think having the numbers in one place is good practice.

D3D12 behaviour is a mess, all drviers allow creating view descriptor heaps with >1M descriptors, but creating a heap too large can either return E_OUTOFMEMORY or remove the device entirely.

@doitsujin doitsujin force-pushed the descriptor-count-cleanup branch 2 times, most recently from f6ba834 to 2a02381 Compare December 3, 2024 10:13
@doitsujin doitsujin marked this pull request as ready for review December 3, 2024 10:13
@HansKristian-Work HansKristian-Work merged commit 4c6bbce into HansKristian-Work:master Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants