Only allocate device memory if explicitly requested #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
force-pushed
the
memory-fallback-thing
branch
from
3227a46 to
5f8b1fb
Compare
NVK currently only exposes VRAM, HVV and cached sysmem in that order, which essentially breaks no_upload_hvv because the first memory type with HOST_VISIBLE | HOST_COHERENT set is HVV. Signed-off-by: Philip Rebohle <[email protected]>
Signed-off-by: Philip Rebohle <[email protected]>
doitsujin
force-pushed
the
memory-fallback-thing
branch
from
5f8b1fb to
ff2badc
Compare
|
Confirmed, games no longer run into "out of video memory" errors on NVK (current git as of writing this comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches DXVK behaviour and should fix #2258, but needs testing.
The idea here is that if we want to allocate system memory (as a fallback or otherwise, e.g.
UPLOADheaps in an app that also uses GPU upload heaps), we should never try to allocate from device-local memory unless all supported memory types for a given allocation are device-local.Also fixes the possible case where a fallback allocation with no property flags would attempt to allocate from
DEVICE_LOCALagain. This only hasn't been an issue so far because most drivers allow oversubscribing VRAM, but this is not guarateed.