Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 7 #318

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Support Symfony 7 #318

merged 2 commits into from
Jul 27, 2024

Conversation

Niiph
Copy link
Contributor

@Niiph Niiph commented Jan 9, 2024

Since symfony/property-access 7.0 requires php8.2 and php8.2 had some changes in datetime format: https://www.php.net/manual/en/datetime.formats.php (end of document) I had to make some changes
@peter-gribanov

@Niiph Niiph force-pushed the Symony-7-support branch 3 times, most recently from 1b6f9dc to eb7dd61 Compare January 9, 2024 13:51
@Niiph Niiph marked this pull request as draft January 9, 2024 15:59
@Niiph Niiph marked this pull request as ready for review January 10, 2024 18:05
@jack-worman
Copy link

@peter-gribanov Please review

@Niiph
Copy link
Contributor Author

Niiph commented May 22, 2024

@Nyholm

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I am happy with this.

Maybe @peter-gribanov wants to have a look too as he is the active maintainer.

@fractalzombie
Copy link

Guys, we need this PR, cause any team can't use symfony 7.X

@Niiph
Copy link
Contributor Author

Niiph commented Jul 27, 2024

Guys, we need this PR, cause any team can't use symfony 7.X

just go with this fork:

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/Niiph/Doctrine-Specification"
        }
    ]

it's not ideal solution but should give you ability to go with Symfony 7

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this.

I can't merge atm. On my phone and CI is not 100% green

@Nyholm Nyholm merged commit 15fa597 into Happyr:2.x Jul 27, 2024
15 of 17 checks passed
@Nyholm
Copy link
Member

Nyholm commented Jul 27, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants