Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hxb] Optimistic display requests #11866

Merged
merged 12 commits into from
Jan 20, 2025
Merged

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Dec 10, 2024

Limits the number of modules restored during display requests, which is especially useful on projects with lots of inter dependencies.

@Simn
Copy link
Member

Simn commented Dec 10, 2024

Oh dear...

@kLabz
Copy link
Contributor Author

kLabz commented Dec 11, 2024

I will rebase after #11872 and #11873 are merged to get a cleaner PR here.

Will keep it opt-in (and a draft) for now, still waiting on more data from shiro devs and will likely have a thing or two to fix.

@skial skial mentioned this pull request Dec 11, 2024
1 task
@kLabz kLabz force-pushed the hxb/optimistic-display-requests branch 2 times, most recently from e4b0e03 to ff8caa2 Compare December 12, 2024 13:24
src-json/define.json Outdated Show resolved Hide resolved
@kLabz kLabz force-pushed the hxb/optimistic-display-requests branch from 7317a07 to ff52375 Compare December 13, 2024 19:29
@kLabz kLabz marked this pull request as ready for review December 13, 2024 19:31
@kLabz kLabz force-pushed the hxb/optimistic-display-requests branch from bc65296 to 53d665f Compare December 14, 2024 09:51
@kLabz kLabz force-pushed the hxb/optimistic-display-requests branch from 53d665f to b674071 Compare December 14, 2024 09:53
kLabz added 4 commits January 16, 2025 14:30
Something's wrong there, getting Dynamic fields in display requests.
Need to investigate and add that lazy wrapping again in another PR.
@kLabz kLabz merged commit 30769c6 into development Jan 20, 2025
93 of 96 checks passed
@kLabz kLabz deleted the hxb/optimistic-display-requests branch January 21, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants