[hlc] Fix SMOD/SDIV overflow exception when INT_MIN / -1 #11917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI shows that cpp / neko also suffer from this integer overflow exception; jvm/php does not like div by zero but I think that's ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: HaxeFoundation/hashlink#730
Related PR for HL/JIT (need merge there first for CI): HaxeFoundation/hashlink#740
I added some overflow exception tests that can also cause problem on others targets (e.g. Neko fail in silence on try haxe), I can add a
if hlif necessary