feat: improves indirect recursion detection #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HiDeoo
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Thanks for your contribution 🙌
I took the liberty of changing the line endings to LF in one of the files so we can merge this PR right away but other than that, this looks really great to me, building on top of the existing check, improving it and adding tests for the changes. 🌟
HiDeoo
changed the title
|
@HiDeoo is this change included in the latest version ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR adds a recursion check by passing an array of parent schemas down the component chain and checking if a particular schema is already in it before rendering the object.
Sample schemas and unit tests were included to validate the issue is fixed by this change.
Why
These changes avoid the build hanging as described in #41
How
The
.astrocomponents involved in rendering schema objects all got aparentsproperty which receives an array ofSchemaObjectrepresenting their parents, in theSchemaObjectObjectPropertiescomponent the single parent property was replaced by the newparentsproperty and the existing "parent" check now considers the array instead of the single object.