Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#629 Monadic operations inside match nested inside with have unexpected behaviour #652

Merged
merged 3 commits into from
Aug 2, 2024
Merged

#629 Monadic operations inside match nested inside with have unexpected behaviour #652

merged 3 commits into from
Aug 2, 2024

Conversation

imaqtkatt
Copy link
Contributor

No description provided.

@imaqtkatt imaqtkatt requested a review from developedby August 1, 2024 12:58
@imaqtkatt imaqtkatt self-assigned this Aug 1, 2024
@imaqtkatt imaqtkatt linked an issue Aug 1, 2024 that may be closed by this pull request
Monadic operations inside match nested inside with have unexpected behaviour #629
Open
developedby
developedby requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@developedby developedby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test with mismatched final statements? A return in one branch and an ask in the other, and a assignment in one branch and an ask in the other

src/imp/parser.rs Outdated Show resolved Hide resolved
@imaqtkatt imaqtkatt requested a review from developedby August 1, 2024 18:44
developedby
developedby requested changes Aug 2, 2024
View reviewed changes
Copy link
Member

@developedby developedby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the changelog

@imaqtkatt imaqtkatt requested a review from developedby August 2, 2024 14:34
developedby
developedby approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@developedby developedby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, well done

@imaqtkatt imaqtkatt added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit c426087 Aug 2, 2024
5 checks passed
@imaqtkatt imaqtkatt deleted the 629-monadic-operations-inside-match-nested-inside-with-have-unexpected-behaviour branch August 2, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developedby developedby developedby approved these changes

Assignees

@imaqtkatt imaqtkatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monadic operations inside match nested inside with have unexpected behaviour
2 participants
@imaqtkatt @developedby