utils/pypi: fix an incorrect return type #15753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This return type is inconsistent with the parent signature, and was causing a checked type error with Sorbet on
brew-pip-audit
: https://github.com/Homebrew/brew-pip-audit/actions/runs/5654213254/job/15316828558From a quick look, it appears to be vestigial from an older (pre-typechecked) version of this API. Returning
nil
instead makes sense, since the return here indicates the same error mode as the othernil
returns above.CC @alex