Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/pypi: fix an incorrect return type #15753

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

woodruffw
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This return type is inconsistent with the parent signature, and was causing a checked type error with Sorbet on brew-pip-audit: https://github.com/Homebrew/brew-pip-audit/actions/runs/5654213254/job/15316828558

From a quick look, it appears to be vestigial from an older (pre-typechecked) version of this API. Returning nil instead makes sense, since the return here indicates the same error mode as the other nil returns above.

CC @alex

@woodruffw
Copy link
Member Author

Proximate underlying cause here is konradhalas/dacite#235.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @woodruffw!

@MikeMcQuaid MikeMcQuaid enabled auto-merge July 25, 2023 14:48
@MikeMcQuaid MikeMcQuaid merged commit 712a824 into Homebrew:master Jul 25, 2023
@woodruffw woodruffw deleted the ww/bad-type branch July 25, 2023 15:02
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants