swift 5.9.2

[razvanazamfirei]

Created by brew bump

---

Created with brew bump-formula-pr.

• resource blocks have been checked for updates.

[Bo98]

Will have more time to look into issues here unlike last time now that Ruby 3 is basically done.

All the changes in the original Swift 5.9 PR should however apply here (except the CMake patch)

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

[SMillerDev]

We'll need to try this again later I guess.

The self-hosted runner: 12-arm64-7978145460-2 lost communication with the server. Verify the machine is running and has a healthy network connection. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

[finagolfin]

No matter what, it seems pkg-config is not respected.

I doubt that, since it worked with 5.8, though as you say we cannot account for spuriously installed headers. You can try running the failing SwiftPM command manually with the --vv flag, to make sure it is invoking pkg-config correctly.

[Bo98]

You can reproduce the same issue in the official Docker image. That indicates to me that it's not a Homebrew-specific problem:

$ docker run --rm -it swift:5.9.2
# apt update
# apt install g++ make cmake curl
# cd /root
# curl -LO https://www.sqlite.org/2024/sqlite-autoconf-3450100.tar.gz
# tar xf sqlite-autoconf-3450100.tar.gz
# cd sqlite-autoconf-3450100
# ./configure --prefix=/opt/prefix
# make install
# cd ..
# export PKG_CONFIG_PATH=/opt/prefix/lib/pkgconfig
# pkg-config --cflags sqlite3
-I/opt/prefix/include
# git clone https://github.com/apple/swift-package-manager
# cd swift-package-manager
# git checkout swift-5.9.2-RELEASE
# swift build
/root/swift-package-manager/.build/checkouts/swift-llbuild/lib/Core/SQLiteBuildDB.cpp:28:10: fatal error: 'sqlite3.h' file not found
#include <sqlite3.h>
         ^~~~~~~~~~~
1 error generated.

--vv does not show any pkg-config line. --pkg-config-path vs PKG_CONFIG_PATH makes no difference

[finagolfin]

Oh, just thought of it and looked it up, maybe you need to add Homebrew as a linux packager in SwiftPM?

[Bo98]

That's a fair point that Homebrew for Linux should probably be added to that in order to make things work without needing to manually specify PKG_CONFIG_PATH (though not entirely sure how to implement a combined Homebrew + system package manager setup given pkg-config only respects the first provider: https://github.com/apple/swift-package-manager/blob/058574d8aa40dbc7d9208b44164d8cff622b9b72/Sources/PackageLoading/Target%2BPkgConfig.swift#L76)

Though the result of that is always merged with PKG_CONFIG_PATH, so ultimately the result is the same to what we're already doing here for llbuild: https://github.com/apple/swift-package-manager/blob/98747d519cab0a5e0a1610ccf8d558cbd4099454/Sources/PackageLoading/PkgConfig.swift#L82

[finagolfin]

--vv does not show any pkg-config line.

Stick a swift package clean in right before checking the verbose output, or at some point SwiftPM stops running pkg-config and just uses the cached build config. I had no problem seeing the pkg-config invocation on Fedora linux just now with the system Swift 5.8.1, except after a couple swift build invocations without cleaning in between.

Though the result of that is always merged with PKG_CONFIG_PATH, so ultimately the result is the same to what we're already doing here for llbuild

Obviously not, as something is going wrong: you'll probably need to step through with a debugger or build a SwiftPM that prints some output to figure this out.

[Bo98]

Stick a swift package clean in right before checking the verbose output, or at some point SwiftPM stops running pkg-config and just uses the cached build config. I had no problem seeing the pkg-config invocation on Fedora linux just now with the system Swift 5.8.1, except after a couple swift build invocations without cleaning in between.

I see

debug: pkg-config --variable pc_path pkg-config

but that's about it.

And just to confirm pkg-config works, I ran:

// swift-tools-version: 5.9

import PackageDescription

let package = Package(
    name: "libTest",
    targets: [
        .systemLibrary(name: "testsqlite3", pkgConfig: "sqlite3"),
        .target(name: "libTest", dependencies: ["testsqlite3"]),
    ]
)

And it works fine (note the -I/opt/prefix/include):

debug: pkg-config --variable pc_path pkg-config
Building for debugging...
/usr/bin/clang -target aarch64-unknown-linux-gnu -g -O0 -DSWIFT_PACKAGE=1 -DDEBUG=1 -fblocks -fmodules -fmodule-name=libTest -I /tmp/swifttest/Sources/libTest/include -fmodule-map-file=/tmp/swifttest/Sources/testsqlite3/module.modulemap -I/opt/prefix/include -fmodules-cache-path=/tmp/swifttest/.build/aarch64-unknown-linux-gnu/debug/ModuleCache -fPIC -fno-omit-frame-pointer -MD -MT dependencies -MF /tmp/swifttest/.build/aarch64-unknown-linux-gnu/debug/libTest.build/main.c.d -c /tmp/swifttest/Sources/libTest/main.c -o /tmp/swifttest/.build/aarch64-unknown-linux-gnu/debug/libTest.build/main.c.o

It only doesn't work with llbuild's Package.swift, which doesn't use .systemLibrary. Note that the SPMSQLite3 in SwiftPM itself, which uses .systemLibrary, compiles and links absolutely fine - no further hacks were necessary beyond llbuild.

[finagolfin]

OK, so pkg-config is run and the pkg-config-path is being set fine for you then, and we go back to the original issue of whether SwiftPM's dependency on SQLite should be applied to llbuild also. I figured it was, since it cross-compiles fine for me, but as I said a couple weeks ago, I wasn't sure.

We'll need to dig into that next.

[Bo98]

Something to compare between us would be this verbose output of SQLiteBuildDB.cpp.o (this one's from the Swift Docker image, so might be a little different if running a full Swift build):

/usr/bin/clang -target aarch64-unknown-linux-gnu -g -O0 -DSWIFT_PACKAGE=1 -DDEBUG=1 -fblocks -fmodules -fmodule-name=llbuildCore -I /root/swift-package-manager/.build/checkouts/swift-llbuild/lib/Core/include -I /root/swift-package-manager/.build/checkouts/swift-llbuild/lib/Basic/include -fmodule-map-file=/root/swift-package-manager/.build/aarch64-unknown-linux-gnu/debug/llbuildBasic.build/module.modulemap -I /root/swift-package-manager/.build/checkouts/swift-llbuild/lib/llvm/Support/include -fmodule-map-file=/root/swift-package-manager/.build/aarch64-unknown-linux-gnu/debug/llvmSupport.build/module.modulemap -I /root/swift-package-manager/.build/checkouts/swift-llbuild/lib/llvm/Demangle/include -fmodule-map-file=/root/swift-package-manager/.build/aarch64-unknown-linux-gnu/debug/llvmDemangle.build/module.modulemap -fmodules-cache-path=/root/swift-package-manager/.build/aarch64-unknown-linux-gnu/debug/ModuleCache -fPIC -fno-omit-frame-pointer -MD -MT dependencies -MF /root/swift-package-manager/.build/aarch64-unknown-linux-gnu/debug/llbuildCore.build/SQLiteBuildDB.cpp.d -std=c++14 -c /root/swift-package-manager/.build/checkouts/swift-llbuild/lib/Core/SQLiteBuildDB.cpp -o /root/swift-package-manager/.build/aarch64-unknown-linux-gnu/debug/llbuildCore.build/SQLiteBuildDB.cpp.o

Note that it's missing -I/opt/prefix/include. Where does your pkg-config --cflags sqlite3 point to and do you see those flags passed to the compiler?

[finagolfin]

Where does your pkg-config --cflags sqlite3 point to and do you see those flags passed to the compiler?

I'll schedule a build tomorrow and check. It's possible that since the Termux build also sets CFLAGS, the llbuild dependency is fulfilled by that, while --pkg-config-path only applies to the SwiftPM dependency on SQLite. I will run a verbose build and let you know why it worked for me.

[finagolfin]

Alright, ran a verbose build that removed the --pkg-config-path flags, finagolfin/termux-packages@32fc996ec. It shows pkg-config invoked, SQLiteBuildDB.cpp.o still building fine (implying it's getting that include directory from CFLAGS or elsewhere, not from pkg-config), and the final link fails because it's missing the path to the cross-compiled SQLite library, which pkg-config did supply before I disabled the --pkg-config-path flags for this run.

It appears you are right that llbuild will require making its SQLite dependency explicit, and your previous 5.8 Homebrew build and my Termux builds happened to work for other reasons.

[Bo98]

Thanks for checking that! Indeed, final link seems to work as expected.

I think we can consider this being reported as swiftlang/swift-llbuild#901

[github-actions]

🤖 An automated task has requested bottles to be published to this PR.