Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syck: disable #167573

Merged
merged 1 commit into from
Mar 30, 2024
Merged

syck: disable #167573

merged 1 commit into from
Mar 30, 2024

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

See indeyets/syck#21 and #139929

@github-actions github-actions bot added formula disabled Formula disabled no Linux bottle Formula has no Linux bottle labels Mar 30, 2024
@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Mar 30, 2024
@chenrui333
Copy link
Member

image

chenrui333
chenrui333 reviewed Mar 30, 2024
View reviewed changes
Formula/s/syck.rb Outdated Show resolved Hide resolved
@SMillerDev @chenrui333
syck: disable
85dafcf 
syck: fix code style and attach upstream issue

Signed-off-by: Rui Chen <[email protected]>
@p-linnane p-linnane added this pull request to the merge queue Mar 30, 2024
Merged via the queue into Homebrew:master with commit 10e8fc1 Mar 30, 2024
16 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label May 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula disabled Formula disabled no Linux bottle Formula has no Linux bottle outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SMillerDev @chenrui333 @p-linnane