Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dafny: align deprecation with dotnet@6 and drop Ventura bottle #182283

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Aug 24, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Ventura has some issue with dotnet@6 so needed to drop the bottle. Do the same here to avoid failing tests.

Should be able to trigger a bottle request for Sonoma now.

Given we previously weren't able to bottle on dotnet@6 on Sonoma, the issue is most likely Xcode 15.0 - 15.2 related and fixed in Xcode 15.3. Could be something like the new linker.

@cho-m cho-m added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 24, 2024
@github-actions github-actions bot added java Java use is a significant feature of the PR or issue formula deprecated Formula deprecated dotnet .NET use is a significant feature of the PR or issue labels Aug 24, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 24, 2024
Merged via the queue into master with commit 6708a29 Aug 24, 2024
17 checks passed
@BrewTestBot BrewTestBot deleted the dafny-net6 branch August 24, 2024 15:23
@chenrui333
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. dotnet .NET use is a significant feature of the PR or issue formula deprecated Formula deprecated java Java use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants