Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8주차]Cow_mvc_practice(fuirian) #8

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

fuirian
Copy link

@fuirian fuirian commented May 14, 2024

@fuirian fuirian requested review from Hoya324 and KoSeonJe as code owners May 14, 2024 15:37
Copy link
Collaborator

@TaetaetaE01 TaetaetaE01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한번 더 확인하시면서 고치시면 좋아보입니다! comment밖에 안보이는데 혹시 다른 도메인은 아직 못 올리신건가요!?


private final CommentService commentService;

@PostMapping("/api/comments")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/api/comments 경로는 클래스위에 @RequestMapping으로 전체 경로 지정해주세요.

Comment on lines 36 to 39
@GetMapping("/api/comments/{commentId}")
public void findComment(@PathVariable long commentId) {
Comment comment = commentService.findComment(commentId);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

db에서 정보를 가져오는 부분인데 response가 존재하지 않습니다

@Getter
public class CommentRequest {

private Member member;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Member로 선언하면 json파싱이 되나요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants